🧑🏼🏫 Add support for sphinx exercise #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2023
rowanc1
commented
May 28, 2023
| @@ -49,6 +57,20 @@ function getDefaultNumberedReferenceLabel(kind: TargetKind | string) { | |||
| } | |||
| } | |||
|
|
|||
| function getDefaultNamedReferenceLabel(kind: TargetKind | string, hasTitle: boolean) { | |||
There was a problem hiding this comment.
This function should eventually be moved to be added/accessible from the directives. Currently this is hard-coded in the transforms.
|
@mmcky @choldgraf the docs for the sphinx exercise extension are here: Let me know your thoughts!! |
71 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for sphinx-exercise, cc @mmcky as well as a number of small improvements around cross-references (no nested links inside a cross-ref link) as well as general support for gated directives.
See jupyter-book/myst-theme#104